Skip to content

feat: add a "country" property to the current_workspace#273

Merged
nazarfil merged 7 commits into
mainfrom
feat/workspace-country
Jun 20, 2025
Merged

feat: add a "country" property to the current_workspace#273
nazarfil merged 7 commits into
mainfrom
feat/workspace-country

Conversation

@plmercereau

@plmercereau plmercereau commented Jun 19, 2025

Copy link
Copy Markdown
Contributor

Changes

Add a countries property to the current workspace, so it can be used in pipelines

@nazarfil

Copy link
Copy Markdown

Great addition, I will move the GraphQL query to the codegen implementation before merging (it is new, as in this example) : https://github.com/BLSQ/openhexa-sdk-python/blob/main/openhexa/cli/graphql/graphql_client/get_workspace_pipelines.py

@plmercereau

Copy link
Copy Markdown
Contributor Author

@nazarfil I just realised the UI actually allowed selecting mutliple countries. I think we should rename the property to countries and return a list - and not raise warnings / errors when list length is 0 or 1.
I can do it once you changed the graphql codegen thingy

@nazarfil nazarfil force-pushed the feat/workspace-country branch 2 times, most recently from 04a3462 to faa4c2b Compare June 19, 2025 12:42
@nazarfil nazarfil force-pushed the feat/workspace-country branch from faa4c2b to 6fe4f20 Compare June 19, 2025 12:46
@nazarfil nazarfil force-pushed the feat/workspace-country branch 3 times, most recently from 01c83c7 to 4ebbafe Compare June 19, 2025 12:57
@nazarfil nazarfil force-pushed the feat/workspace-country branch from 4ebbafe to 5b64d22 Compare June 19, 2025 12:57
@nazarfil nazarfil requested review from bramj and yolanfery June 20, 2025 07:40

@yolanfery yolanfery left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@nazarfil nazarfil merged commit d942273 into main Jun 20, 2025
4 checks passed
@nazarfil nazarfil deleted the feat/workspace-country branch June 20, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants